search

whosonfirst / go-whosonfirst-updated

(Too soon. Move along.)
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Make S3 local-file-not-found warnings quiet #8

Closed thisisaaronland closed 7 years ago

thisisaaronland commented 7 years ago

This is happening in go-whosonfirst-s3 but it manifests itself during updated events

thisisaaronland commented 7 years ago

This is not actually a go-whosonfirst-s3 thing, but an issue in process/s3.go:

./src/github.com/whosonfirst/go-whosonfirst-updated/process/s3.go:127:          pr.logger.Warning(fmt.Sprintf("Failed to clone %s, because it doesn't exist", abs_path))
thisisaaronland commented 7 years ago

Hrm... per the comments, maybe we don't want this code to be quiet and we are better filtering stuff here:

https://github.com/whosonfirst/go-webhookd/blob/master/transformations/github.commits.go#L53-L56

thisisaaronland commented 7 years ago

See also : https://github.com/whosonfirst/go-webhookd/tree/filtered

thisisaaronland commented 7 years ago

We are now testing the filtered branch of webhookd in production.

thisisaaronland commented 7 years ago

https://github.com/whosonfirst/go-whosonfirst-updated/issues/11