search

whosonfirst / py-mapzen-whosonfirst-bundles

A Python package to generate Who's On First data bundles.
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Please add postalcode to bundles #4

Closed vesameskanen closed 8 years ago

vesameskanen commented 8 years ago

wof-postalcode-latest.csv seems to be empty at the moment. It would be nice to get that data into the bundles as well. We would use it to add missing postalcodes to our Pelias geocoding data.

thisisaaronland commented 8 years ago

Hopefully, this will be sorted out by the middle of next week. I will spare you to boring details until I have to bore you with the details to explain why it's more complicated than I'd hoped, but hopefully it won't be.

This is all wrapped up in some of the discontinuities around how placetypes and individual repos are organized and how the code has evolved around those facts. But you are not the only person asking for stuff like this so it's time...

More soon!

thisisaaronland commented 8 years ago

Notes to self:

This assumes you're already in whosonfirst-data-postalcode-fi

wof-placetype-to-csv -R . -l -p postalcode
wof-bundle-placetypes -R . -d /usr/local/data/whosonfirst-bundles/ -p postalcode -S latest --aws-bucket whosonfirst.mapzen.com --wof-clone /usr/local/bin/wof-clone-metafiles
thisisaaronland commented 8 years ago

@vesameskanen - When you have a moment can you take a look at the files listed below and confirm that they are what you're after?

I am still working through the mechanics of how/where to automate bundles for non-admin (the default whosonfirst-data repo) placetypes but in the meantime:

http://whosonfirst.mapzen.com.s3.amazonaws.com/bundles/wof-postalcode-fi-latest-bundle.tar.bz2

http://whosonfirst.mapzen.com.s3.amazonaws.com/bundles/wof-postalcode-fi-latest-bundle.tar.bz2.sha1.txt

http://whosonfirst.mapzen.com.s3.amazonaws.com/bundles/wof-postalcode-fi-latest.csv

http://whosonfirst.mapzen.com.s3.amazonaws.com/bundles/wof-postalcode-fi-latest.csv.sha1.txt

vesameskanen commented 8 years ago

Hi @thisisaaronland - many thanks for the data links above. This seems to be the data we need. I tested Pelias WOF mapping with a new postalcode extension and the data above. 97 % of tested FI address entries with a known postalcode mapped correctly. The 3 % difference is probably caused by source data errors and maybe also by Pelias WOF mapping inaccuracy.

thisisaaronland commented 8 years ago

Perfect! These will be automated shortly although given (relatively) rarely postal codes change it may be a moot point :-)