search

whosonfirst / py-mapzen-whosonfirst-export

Export tools for the Who's On First documents
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Investigate "grumpy" for generating binary tools #10

Closed thisisaaronland closed 5 years ago

thisisaaronland commented 7 years ago

https://opensource.googleblog.com/2017/01/grumpy-go-running-python.html

thisisaaronland commented 7 years ago

Tried this with git-whosonfirst-data and it appears that the first step is to ensure that anything you import in python has to have already been go-grumpy-fied which means this is probably too soon for us to use:

go build -o pre-commit pre-commit.go 
pre-commit.go:4:2: cannot find package "grumpy/lib/logging" in any of:
    /usr/local/go/src/grumpy/lib/logging (from $GOROOT)
    /usr/local/mapzen/wof/grumpy/build/src/grumpy/lib/logging (from $GOPATH)
pre-commit.go:5:2: cannot find package "grumpy/lib/mapzen" in any of:
    /usr/local/go/src/grumpy/lib/mapzen (from $GOROOT)
    /usr/local/mapzen/wof/grumpy/build/src/grumpy/lib/mapzen (from $GOPATH)
pre-commit.go:6:2: cannot find package "grumpy/lib/mapzen/whosonfirst" in any of:
    /usr/local/go/src/grumpy/lib/mapzen/whosonfirst (from $GOROOT)
    /usr/local/mapzen/wof/grumpy/build/src/grumpy/lib/mapzen/whosonfirst (from $GOPATH)
pre-commit.go:7:2: cannot find package "grumpy/lib/mapzen/whosonfirst/git" in any of:
    /usr/local/go/src/grumpy/lib/mapzen/whosonfirst/git (from $GOROOT)
    /usr/local/mapzen/wof/grumpy/build/src/grumpy/lib/mapzen/whosonfirst/git (from $GOPATH)
pre-commit.go:11:2: cannot find package "grumpy/lib/subprocess" in any of:
    /usr/local/go/src/grumpy/lib/subprocess (from $GOROOT)
    /usr/local/mapzen/wof/grumpy/build/src/grumpy/lib/subprocess (from $GOPATH)
pre-commit.go:13:2: cannot find package "grumpy/lib/wof" in any of:
    /usr/local/go/src/grumpy/lib/wof (from $GOROOT)
    /usr/local/mapzen/wof/grumpy/build/src/grumpy/lib/wof (from $GOPATH)
pre-commit.go:14:2: cannot find package "grumpy/lib/wof/common" in any of:
    /usr/local/go/src/grumpy/lib/wof/common (from $GOROOT)
    /usr/local/mapzen/wof/grumpy/build/src/grumpy/lib/wof/common (from $GOPATH)
thisisaaronland commented 5 years ago

Closing because it just makes more sense to port all this functionality to plain old Go.