search

whosonfirst / py-mapzen-whosonfirst-export

Export tools for the Who's On First documents
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

date:* vs edtf:* #17

Open stepps00 opened 6 years ago

stepps00 commented 6 years ago

https://github.com/whosonfirst/py-mapzen-whosonfirst-export/blame/master/mapzen/whosonfirst/export/__init__.py#L195-L196

A recent commit added logic to the export code to add date:inception_lower and date:inception_upper properties when an edtf:inception date is present.

I think this should be edtf:inception_upper and edtf:inception_lower, instead, to be consistent with the other date properties. If so, I'll file a PR with an update and catalogue the new props in the properties repo.

stepps00 commented 6 years ago

Opened https://github.com/whosonfirst/whosonfirst-properties/issues/76 to catalogue the new properties.