whosonfirst / py-mapzen-whosonfirst-export

Export tools for the Who's On First documents
BSD 3-Clause "New" or "Revised" License
2 stars 3 forks source link

Should we backfill empty iso:country props? #27

Open stepps00 opened 4 years ago

stepps00 commented 4 years ago

https://github.com/whosonfirst/py-mapzen-whosonfirst-export/blob/master/mapzen/whosonfirst/export/__init__.py#L253-L263

Less an issue, more of an open question - when an iso:country property is an empty string or not present, should we be backfilling that property using the value in wof:country?

Right now, if the iso:country property value is "", the export tool backfills the value, using the wof:country property value. There have been previous discussions around wof:country vs iso:country codes, so I'm thinking we can remove that logic.