search

whosonfirst / py-mapzen-whosonfirst-lieu

Who's On First utilities for working with the lieu toolchain.
BSD 3-Clause "New" or "Revised" License
0 stars 0 forks source link

Account for expired (NYC DCA) licenses when processing dupes #1

Open thisisaaronland opened 7 years ago

thisisaaronland commented 7 years ago

For example:

WARNING:root:353894419 already has a concordance with nycgov_dca:license (0892156-DCA) - what is nycgov_dca:license (0901990-DCA)

The former has an expiry date of 07/31/2017 but the latter has an expiry date of 06/30/2018. It's almost like the solution to this nonsense might be... stable permanent identifiers?

This will effectively force the issue of how/where to add "alt" concordances to a WOF record. Probably the cleanest thing is to add a wof:concordances_alt property where the keys are strings (the same keys as wof:concordances) and the values are a lists... TBD.

thisisaaronland commented 7 years ago

Notes to self: Assuming we did something like https://github.com/whosonfirst/py-mapzen-whosonfirst-lieu/issues/2 we would still need a flag to tell the add_concordance method to override the existing concordance...