Closed stepps00 closed 4 years ago
@stepps00 You are correct about the dependency on Go 1.12 or higher. As a general rule I hate requiring stuff like this but because Go modules, in general, make life easier it seems like an acceptible trade-off.
Running the combined dist code against the current state of the per-country repos successfully created a ~8gb compressed (~35gb uncompressed) combined file with 5.3M admin records.
Related:
Notes from the "combined" distribution here: https://gist.github.com/stepps00/47a42d80b4e2cd5fee7fcf10989c284e
I'd like to create two cookbook docs, one on creating a distribution for a single repository (essentially just update this one) and one with the new "combined" logic, as outlined in the gist.
I'll re-run the combined dist code today to create a new dist file and to confirm the steps in this Gist are correct, then update the cookbook docs.
~Note that the "combined" data distributions also include constituency
repos. Update any command line lists of repos to include the constituency
repos.~
Arguably constituency
is included in the "admin" combo dist in error? If it's always been there then we can consider keeping it as a documented oddity?
The constituency comment was a mistake on my end - they should not be included in the combined admin distribution.. (they have their own distribution).
I've updated docs in #34, mostly using the steps outlined in https://gist.github.com/stepps00/47a42d80b4e2cd5fee7fcf10989c284e
Since the existing (outdated) how-to doc is linked in other whosonfirst repos/docs, rather than renaming/deleting the existing doc, I deprecated it and linked to the new documentation.
Since the whosonfirst-data repo has split into per-country repos, update the dist cookbook document to reflect the new changes. The
-combined
flag requires passing all the new repo names, so the new command to get all the admin data is something like:Also add the caveat that Go 1.12 is required. 1.10 seems to not like
-mod vendor
.