search

whosonfirst / whosonfirst-cookbook

Instructions and How-To Documentation for Who's on First
15 stars 2 forks source link

Create lookup table of placetype counts by country #40

Closed stepps00 closed 4 years ago

stepps00 commented 4 years ago

Fixes https://github.com/whosonfirst/whosonfirst-cookbook/issues/39

Creates a new lookup chart with placetype counts per country (based on per-country repo crawls). Doesn't include records with "mz:is_current":0, though I have those counts too, and can add to a separate chart if useful.

nvkelso commented 4 years ago

Looking good!

  1. To make it easier to interoperate with other datasets, can you add new columns for iso3, please?
  2. And then it's hard to know if the rows are country or dependency so consider adding a "placetype" column?
stepps00 commented 4 years ago

https://github.com/whosonfirst/whosonfirst-cookbook/pull/40#issuecomment-671598747 taken care of in the most recent commits.

@nvkelso - take a look at the current chart formatting/data and let me know if anything else needs adjusting. I added in a "placetype" column for most repos.

nvkelso commented 4 years ago

Great to see the table changes. More questions:

image

stepps00 commented 4 years ago

Looks like the French dependency aren't reporting correctly, I see blank cells in that placetype column.

This table is based on placetype counts, per admin repo. In the French dependency cases, WOF classifies them at the region placetype. I only included dependency and country placetypes here, but I can adjust to include regions, too.

What are XX, XY, XZ? Why do those have "unknown" name? I think they mean something special and generic...

These represent the placetype counts in each of the "unknown" placeholder repos. The best description for each is here: https://github.com/whosonfirst/whosonfirst-placetypes#iso-country-codes

In the same area of the scresnshot below, why are those missing country placetype?

Good catch, I need to add country to the "Kosovo", "Null Island", and "Somaliland" rows.. I'll add in a new commit.

stepps00 commented 4 years ago

I'm re-running the placetype counts to confirm data in this chart, then I'll merge.