JSON Updates - Githubissues

whosonfirst / whosonfirst-properties

What things mean in Who's On First documents

Other

5 stars 5 forks source link

JSON Updates #37

Closed stepps00 closed 7 years ago

stepps00 commented 7 years ago

Fixes #36.

Created a folder for each property name
Moved the markdown file into the appropriate folder, rename each to README.md
For each property description, created a .json file with:
- an id property (unique)
- a name property (property name)
- a prefix property (what prefix/folder it belongs to)
- a description property (property description)
- a type property (string, integer, float, list, etc)

Other issues have been opened in this repo as follow-ups once this PR is merged.

thisisaaronland commented 7 years ago

The convention has been city since the addr namespace is most closely associated with OSM.

nvkelso commented 7 years ago

Please remove files like: properties/label/.DS_Store. Those are annoying macOS invisible files that Git still sees (you can add them to the .gitignore file, though).

thisisaaronland commented 7 years ago

Let's just leave things as they for now. There is a bunch of code that follows the existing convention and this is a PR for organizing properties and making them accessible to machines, not to redefine practice.

thisisaaronland commented 7 years ago

Again, the point is simply to document what is there. This is not the place to apply wholesale changes to the data.

stepps00 commented 7 years ago

All reviewer comments have been addressed and https://github.com/whosonfirst/whosonfirst-properties/issues/39 has been opened for comment https://github.com/whosonfirst/whosonfirst-properties/pull/37#pullrequestreview-61377844.