Closed vicchi closed 6 years ago
You should:
edtf:deprecated=YYYYMMDD
propertymz:is_current=0
propertyWhat Aaron said :)
On May 9, 2018, at 12:36, Aaron Straup Cope notifications@github.com wrote:
You should:
Add an edtf:deprecated=YYYYMMDD property Add a mz:is_current=0 property — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub, or mute the thread.
@thisisaaronland As properties on the root object? Or in a new properties
object? In other words, should properties/wof/superseded.json
contain ...
{
"id": 1159080455,
"name": "superseded",
"prefix": "wof",
"description": "",
"type": "string",
"edtf:deprecated": "YYYYMMDD",
"mz:is_current": 0
}
or ...
{
"id": 1159080455,
"name": "superseded",
"prefix": "wof",
"description": "",
"type": "string",
"properties": {
"edtf:deprecated": "YYYYMMDD",
"mz:is_current": 0
}
}
... ?
The first.
Closing down this issue as we've now got consensus on and an exemplar of (see #68) deprecating properties.
Based on a discussion as part of PR #66 (see https://github.com/whosonfirst/whosonfirst-properties/pull/66#discussion_r186116373 for context), it's unclear what process to follow when the decision is taken to deprecate a WOF property.
The options seem to be ...
"deprecated": "true"
to the JSON property definition filewhosonfirst-properties/deprecated
andgit mv
the JSON property definition file theregit rm
and let the Git history record this.Note that there's way to many uses of terms such as perhaps or something along the lines of for my comfort. Which means some discussion and hopefully consensus if needed.
But recording this here so it's not forgotten about.