whosonfirst / whosonfirst-properties

What things mean in Who's On First documents
Other
5 stars 5 forks source link

wof:belongsto property contains a mix of strings and integers #71

Closed missinglink closed 6 years ago

missinglink commented 6 years ago

eg: https://data.whosonfirst.org/420/784/501/420784501.geojson

stepps00 commented 6 years ago

This should actually be fixed in the GitHub records, see: https://raw.githubusercontent.com/whosonfirst-data/whosonfirst-data/master/data/420/784/501/420784501.geojson

This PR standardized many properties, including the wof:belongsto property to remove strings. Suggest leaving open until we reconcile GitHub/whosonfirst.org.

missinglink commented 6 years ago

oh damn, I assumed the data.whosonfirst.org data was verbatim the same data as on github, apparently this is not true!

what's the lag between the two?

missinglink commented 6 years ago

also that PR is awesome, fixes a lot of those type issues across the board!

nvkelso commented 6 years ago

oh damn, I assumed the data.whosonfirst.org data was verbatim the same data as on github, apparently this is not true!

This has been true in the past, but they started to diverge a few weeks ago when we started to merge to master again – there were too many PRs that needed to be finished / 2x blocking each other. We're still working thru some workflow kinks to get all the distributions working again (including SQLite and the Spelunker).

nvkelso commented 6 years ago

Closed via https://github.com/whosonfirst-data/whosonfirst-data/pull/1190.

thisisaaronland commented 6 years ago

@missinglink As far as the "update all the things from master" work goes there are a series of overlapping issues/blockers, that include:

It's all being worked on (slowly) but if you just need a fresh SQLite database it can be built manually for now like this:

wof-dist-build {REPO_NAME}

For a complete list of options, pass it the -h flag.