search

whosonfirst / whosonfirst-properties

What things mean in Who's On First documents
Other
5 stars 5 forks source link

deprecate misc properties #72

Closed stepps00 closed 6 years ago

stepps00 commented 6 years ago

https://github.com/whosonfirst/whosonfirst-properties/tree/master/properties/misc

Deprecate existing misc: properties, as they were cleaned up via: https://github.com/whosonfirst-data/whosonfirst-data/pull/979.

Though add a general note that any misc: property is possible, per: https://github.com/whosonfirst/py-mapzen-whosonfirst-export/blob/master/mapzen/whosonfirst/export/__init__.py#L370

nvkelso commented 6 years ago

Why would those creep back in?

On Jun 20, 2018, at 11:17, Stephen Epps notifications@github.com wrote:

https://github.com/whosonfirst/whosonfirst-properties/tree/master/properties/misc

Deprecate existing misc: properties, as they were cleaned up via: whosonfirst-data/whosonfirst-data#979.

Though add a general note that any misc: property is possible, per: https://github.com/whosonfirst/py-mapzen-whosonfirst-export/blob/master/mapzen/whosonfirst/export/__init__.py#L370

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub, or mute the thread.

stepps00 commented 6 years ago

The export code defaults to misc: if a record has a property without a : separator.

nvkelso commented 6 years ago

I think it's fine to keep the export code as is... we just need to document somewhere, like add a README.md to https://github.com/whosonfirst/whosonfirst-properties/tree/master/properties/misc (other dirs there have it, it's missing for misc).