search

whosonfirst / whosonfirst-properties

What things mean in Who's On First documents
Other
5 stars 5 forks source link

Missing Properties from Aliases #98

Closed Guilherme-B closed 4 years ago

Guilherme-B commented 4 years ago

I'm using property_aliases.json to ensure I always have the full list of possible source:label combination. However I did notice there are quite a lot missing, especially when it comes to name:language_x_colloquial. Is this file not supposed to keep track of all the possible combinations present in WOF? If not, is there a file which does?

missinglink commented 4 years ago

I think this is more a list of synonyms rather than a definitive list of all properties?

Guilherme-B commented 4 years ago

Thought so. Any idea if such a definitive list exists?

stepps00 commented 4 years ago

As @missinglink mentioned, this is a specific list of synonyms we maintain for neighbourhood update work. Ultimately, I think this boils down to needing a fix for https://github.com/whosonfirst/whosonfirst-properties/issues/70.

Just to be clear, are you interested in a list of all existing properties in WOF records? I can try to craft something up this week...

Guilherme-B commented 4 years ago

@stepps00 - exactly, one which hopefully can be maintained.

stepps00 commented 4 years ago

Got it.. I'll close this issue out, but track in #70. I've kicked off a simple script to grab all property names, so I'll update that issue once complete.

This has been something I've been meaning to get to, so thanks for the reminder.