search

whosonfirst / whosonfirst-sources

Where things come from in Who's On First.
Other
21 stars 13 forks source link

WIP: Add Karmashapes source file #202

Closed stepps00 closed 1 year ago

stepps00 commented 1 year ago

WIP. Will fix https://github.com/whosonfirst/whosonfirst-sources/issues/201

This PR adds a source json file for the Karmashapes dataset, which links to the generic CC-BY license. This PR also includes a karmashapes_remarks markdown file, based off similar remarks files (mesoshapes, quattroshapes, etc) already in this repo that contain the input source names and links used in the project. The LGA dataset was not included since it was only used as a reference.

If the info in this PR looks good, I'll run the makefile to update supplemental files and merge shortly.

stepps00 commented 1 year ago

cc @justinelliotmeyers

stepps00 commented 1 year ago

Overlooked this.. will handle comments so we can merge now that Karmashapes is in WOF.

stepps00 commented 1 year ago

One comment about the PMGSY source, one comment that I can't seem to resolve (?), and a few merge conflicts..

@nvkelso want to give this one another look? If all looks good, I can resolve the conflicts to get this PR merged..

nvkelso commented 1 year ago

LGTM

stepps00 commented 1 year ago

Unable to fix these merge conflicts, going to open up a separate PR to merge.