Add new sources and concordance usages for old sources

whosonfirst / whosonfirst-sources

Where things come from in Who's On First.

Other

21 stars 13 forks source link

Closed nvkelso closed 9 months ago

nvkelso commented 9 months ago

Related to https://github.com/whosonfirst-data/whosonfirst-data/issues/2164, we need to update which existing sources are also now used for concordances... and add a few new sources.

nvkelso commented 9 months ago

@stepps00 I've also fleshed out the 5 new sources details. This is ready for a 👀 .

It should be merged before any of the related wof-data PRs get merged.

stepps00 commented 9 months ago

Nice - I see both adjustments to existing sources and new sources used for some concordance work in the admin repos.

Calling out three things:

The formatting of the json files looks inconsistent. I see extra carriage returns and spacing in some json files, but not others.
One of these sources has a -1 value on the concordance usage properties.. ideally this can be changed to a 0 or 1, depending on how it is being used in WOF today.
Before merging, this will need a Makefile run (make all)

nvkelso commented 9 months ago

I think your other comments are a no-op? If it's good to go please ✅ approve, thanks!

stepps00 commented 9 months ago

LGTM!