whosonfirst / whosonfirst-www-boundaryissues

Boundary Issues is a web-application for editing Who's On First data.
BSD 3-Clause "New" or "Revised" License
8 stars 1 forks source link

lib_http reports a timeout as 'ok' #200

Open dphiffer opened 7 years ago

dphiffer commented 7 years ago

Looks like when an HTTP request times out lib_http reports it as ok. This is not a Boundary Issues issue specifically, so we should upstream the fix to other Flamework repos.

Here's the $rsp result:

Array
(
    [ok] => 1
    [url] => https://whosonfirst.mapzen.com/data/856/337/93/85633793.geojson
    [info] => Array
        (
            [url] => https://whosonfirst.mapzen.com/data/856/337/93/85633793.geojson
            [content_type] => application/json
            [http_code] => 200
            [header_size] => 396
            [request_size] => 93
            [filetime] => -1
            [ssl_verify_result] => 0
            [redirect_count] => 0
            [total_time] => 2.999971
            [namelookup_time] => 0.063151
            [connect_time] => 0.115543
            [pretransfer_time] => 0.224152
            [size_upload] => 0
            [size_download] => 2399824
            [speed_download] => 799949
            [speed_upload] => 0
            [download_content_length] => 2563843
            [upload_content_length] => 0
            [starttransfer_time] => 0.369194
            [redirect_time] => 0
            [redirect_url] => 
            [primary_ip] => 52.55.20.251
            [certinfo] => Array
                (
                )

            [primary_port] => 443
            [local_ip] => 10.0.2.15
            [local_port] => 60631
            [curl_error] => Operation timed out after 2986 milliseconds with 2399824 out of 2563843 bytes
 received
        )

    [method] => GET
    [req_headers] => Array
        (
            [_request] => GET /data/856/337/93/85633793.geojson HTTP/1.1
            [host] => whosonfirst.mapzen.com
            [accept] => */*
        )

    [headers] => Array
        (
            [_status] => 
        )

    [body] => 
)
dphiffer commented 7 years ago

Kind of awesome that this got issue #200, which is basically the problem ($rsp['info']['http_code'] comes back as 200).