search

whosonfirst / whosonfirst-www-boundaryissues

Boundary Issues is a web-application for editing Who's On First data.
BSD 3-Clause "New" or "Revised" License
8 stars 0 forks source link

LFS dance not happening for all metafiles #273

Closed thisisaaronland closed 7 years ago

thisisaaronland commented 7 years ago

Specifically, LFS files are not expanded. For example:

https://github.com/whosonfirst-data/whosonfirst-data/commit/e3047a467ecf99198b96f9a6a87cb69f082ac4d0

dphiffer commented 7 years ago

Here are some more details about this pipeline: https://whosonfirst.dev.mapzen.com/boundaryissues/pipeline/100/

Have you seen any other examples of this happening, @thisisaaronland? It could be helpful for figuring out what they have in common. Right now it's a bit mysterious to me how some but not all meta files don't get handled by LFS properly.

thisisaaronland commented 7 years ago

Can you point to the specific problem in that pipeline? The only error I see is that the relevant .git credentials haven't been set ?

dphiffer commented 7 years ago

No, I don't see the where problem originated from. My expectation is that LFS would work for all files or for none. The other thing is that since this was one of the early-ish dev pipeline runs, it's possible there was an issue that got worked out.

thisisaaronland commented 7 years ago

Okay, well let's just close this until it happens again since neither one of us can remember what the what is...

dphiffer commented 7 years ago

Works for me!