Closed whotooktwarden closed 9 years ago
@RJTerrible Can you please audit this pull request, sir?
Fixes the improper usage of the include statement (out of scope) and fixes the $operatorEmail assignment into $email_to. Appended semi colons to the echo $gatewayName statements which were missing. Removed mention of an established ripple gateway. Added bootstrap, jquery, modernizr, and a main css file from verekia/initializr-website. Removed the default style.css file.
@ripple Pull request #5 requires review from a third party before it can be marked as completed an merged to the release branch. A third party must also review and close the associated bounties for this pull request.
I apologize for packaging so many commits together at once, I am still learning how to maintain a github, I will create branches for specific features in the future and package smaller pull requests.
I'm closing this pull request so that development can continue. I would have enjoyed at least one other collaborator at this point to perform this merge for me so a third party can confirm these commits do their job and work but alas..
I still require a third party to please, please test the Version 1.0.2 release on Debian 8.1 and/or Ubuntu 14.04 LTS to confirm that the web-kit is functioning properly.
The latest commits pave the way for Version 1.1-1.2. [Please join the discussion](Proposal & Design of Version 1.2 Feature Implementations, an Open Discussion).
Can a community Ripple Developer please close these issues once they have audited Release 1.0.2? Version 1.1.1 Proposal & Design: Create database and create config.php Implement: include.php calls to all pages requiring data replication
This pull request brings the QGK project to release version 1.0.2.
Features:
A shell script for easily getting started with this web-kit on a fresh install of Ubuntu 14.04 LTS. Tested on Ubuntu 14.04 LTS, find recommendations in commit bbec866a0cc3d71705659fce556c33d6b8ef4a18 if you have issues with the database installation (dbcommon-config via phpmyadmin).
Created a PHP file which outlines information which will be replicated in many areas of the web-kit's displayed pages.
Modified these pages to include calls to the include script and variables which store the operator's email and the Gateway's legal business name. This pull request will close Design: include.php when merged to the release branch.
Fixes the improper usage of the include statement and fixes the $operatorEmail variable by assigning the value to $email_to.
Appended semi colons to the echo $gatewayName statements.
Removed mention of an established ripple gateway.