whoward
commented
12 years ago Actually that's a pretty good idea, I'm wondering if we could just generalize the concept a bit and allow filter syntax to be applied anywhere where a variable is used that way. That way all of these would be treated the same to the parse tree:
{{ foo | bar | baz: 123 }}
{% for x in y | foo | bar: 123 %}...{% endfor %}
{% for x in (y | foo | bar: 123) %}...{% endfor %}
{% if posts | empty %}...{% endif %}Doing this would require changing src/cadenza.y and also moving the filter evaluation logic from lib/cadenza/nodes/inject_node.rb to lib/cadenza/nodes/variable_node as well as any fixing specs that'll break so it'll probably be a large commit.
If we can do it without causing any Shift/Reduce or Reduce/Reduce conflicts in the parser then I'd say lets go for it!
joefiorini
Something else I noticed that would make it difficult to convert from Liquid is the lack of "modifiers" on the for loop tag. For example, in Liquid I can do:
This is extremely useful for designers since they don't have much access to filter the collection any other way. What would be even better is the ability to use filters within tags like:
etc.
I believe the latter example would just require a couple small changes to
src/cadenza.y, is that correct? Is that something you'd be interested in having?Thanks! Joe