search

whphhg / vcash-electron

Multi-platform and multi-node GUI for Vcash.
GNU General Public License v3.0
38 stars 18 forks source link

Data folder inconsistency #7

Closed whphhg closed 7 years ago

whphhg commented 7 years ago

I've ran into a couple of issues while packaging the application that I've reported upstream, but until either of those get fixed, the data folder will be incorrectly named Electron if you've cloned and installed the GUI manually and correctly named Vcash Electron GUI in packaged releases.

Initial issue https://github.com/electron-userland/electron-builder/issues/1465#issuecomment-300775108

This is the main issue that I've encountered. While packaging electron-builder says it's pre-compiling using electron-compile but when the application is launched it fails with Error: Asked for /home/.../app.asar/initialize.js but it was not precompiled!.

I was told by the maintainer that he will be investigating soon.

Solution (with the data folder inconsistency compromise) https://github.com/electron-userland/electron-prebuilt-compile/issues/32

As I was trying different things to solve the issue above I found the new (since I last checked) electron-prebuilt-compile that made it possible to package and build a release. The only thing that required changing was moving main.js into the src/ subdirectory.

whphhg commented 7 years ago

The initial issue has been addressed in https://github.com/electron-userland/electron-builder/commit/419cf91783bd18db2d5b7eb19cbaf5afafe0c361. I will test it out and push appropriate changes if successful.

Edit: still fails with the same error. Will require further investigating.

whphhg commented 7 years ago

Thanks to the suggestion I've gotten in the solution's issue I've implemented dynamically set and consistently named userData directories for development and production modes in e1241684a3397f6f7a7001c378c9212004992043.