search

whscullin / apple2js

An Apple II emulator originally written in Javascript, now being converted to TypeScript
http://www.scullinsteel.com/apple2/
MIT License
438 stars 57 forks source link

Split handling of nibble disks and WOZ disks into separate drivers #161

Closed iflan closed 1 year ago

iflan commented 1 year ago

Before, the DiskII object took care of both nibble disks and WOZ disks at the same time. This made it hard to see which code affected which disks.

Now, nibble disks are handled by the NibbleDiskDriver and WOZ disks are handled by the WozDiskDriver. This separation of code should lead to easeir testing and, perhaps, faster evolution of disk handling.

An upcoming change will move the NibbleDiskDriver and the WozDiskDriver to separate files.

This passes all tests, compiles, and runs both nibble disks and WOZ disks.

whscullin commented 1 year ago

Sorry, I wound up merging these out of order, and I think this one can probably just be closed.