search

whscullin / apple2js

An Apple II emulator originally written in Javascript, now being converted to TypeScript
http://www.scullinsteel.com/apple2/
MIT License
438 stars 57 forks source link

NTSC shader #58

Closed whscullin closed 3 years ago

iflan commented 3 years ago

LGTM, but I really can't evaluate whether the shaders are doing what they are supposed to.

whscullin commented 3 years ago

This is still very much a WIP, but I think it has reached a point where I haven't broken anything and the overall visual improvement is substantial, and the performance seems comparable. Next steps would include moving all the duplicate code up into videomodes.ts, and adding some UI to provide access to all the configuration options of apple2shader.

Most of this stuff should be testable, too, but I don't quite have a good bead on the best way to do that.

Before I can land this I need to figure out why npm ci doesn't want to play nice with a public git package. I don't necessarily want to publish apple2shader to npmjs.com but I might if that's the easiest path.