whtan99 / pe

0 stars 0 forks source link

Logger file still named as Adressbook #5

Open whtan99 opened 2 years ago

whtan99 commented 2 years ago

The logger file is still named addressbook.log. This should be updated to reflect your new applications.

Screenshot 2022-04-16 at 2.47.29 PM.png

Steps to reproduce: Open Tracy, go back to root file.

nus-pe-bot commented 2 years ago

Team's Response

Thanks for raising the issue. We believe that this is not part of system or acceptance testing.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: It may be part of system testing.

Your logger files should match your application name or at least a variant of it. Where does addressbook come from? Does it refer to the particular component of your app that stores all the addresses for students?

It's definitely part of acceptance testing.

Screenshot 2022-04-21 at 8.13.05 PM.png

One of the things the customers want to see is error messages in logging files, so they can understand who did what which caused something to go wrong or right in the application.

In the worst case scenario, a customer may not open up the Tracey application in an empty file as we do in the PE. By not naming the logging file correctly, they cannot find the logger file (since the file name is not mentioned in the UG or DG) and this will definitely be raised to the engineering team.