search

whtwnd / whitewind-blog

Repository to manage WhiteWind atproto blogging platform codes
GNU Affero General Public License v3.0
59 stars 5 forks source link

Add NOTICE File with License Information for Dual MIT/Apache-2.0 Compliance #2

Closed nnabeyang closed 5 months ago

nnabeyang commented 5 months ago

The bluesky-social/atproto repository is dual-licensed under MIT and Apache-2.0 licenses. Therefore, it is necessary to include copies of the licenses in the distributed artifacts. However, the repository currently lacks these copies. This PR addresses this issue by creating a NOTICE file and including the license information within it.

nnabeyang commented 5 months ago

@K-Nksm

I believe I misunderstood the handling of dual licensing. Since it is possible to choose either license, I think it is permissible to remove the Apache 2.0 license notation from the NOTICE file. I didn't fully understand because I had never created any deliverables that depended on dual licensing.

Below is a link to a part of the VScode NOTICE file, which serves as an example of dual licensing. https://github.com/microsoft/vscode/blob/main/ThirdPartyNotices.txt#L2064-L2067

K-Nksm commented 5 months ago

From the repository you provided, it seems enough to just mention the author and license terms in a file (ThirdPartyNotices in their case, NOTICE in our case) to comply with MIT license. Therefore this PR properly addresses the license issue. Thank you very much!