why-jay / remark-lint-sentence-newline

Enforce a newline after an end of sentence in Markdown
7 stars 0 forks source link

rework sentence stop detection, support blacklist configuration #15

Closed dirk-thomas closed 8 years ago

dirk-thomas commented 8 years ago

This patch reworks the sentence stop detection. It addresses many tickets at once (with one "regression" though):

why-jay commented 8 years ago

Thanks so much! I'll need some time to review this.

why-jay commented 8 years ago

I added tests against your algorithm, and everything looks good! Thanks for the work.

I think the pros are more significant then the con.

Definitely.

The behavior could also be exposed as an option?

Not for now - I'm too lazy to do the work and I imagine there's no demand. But if there's demand, I will add the option :)

Maybe it should be case insensitive?

Again, this could be an option. If there's demand :)