Closed dirk-thomas closed 8 years ago
Thanks so much! I'll need some time to review this.
I added tests against your algorithm, and everything looks good! Thanks for the work.
I think the pros are more significant then the con.
Definitely.
The behavior could also be exposed as an option?
Not for now - I'm too lazy to do the work and I imagine there's no demand. But if there's demand, I will add the option :)
Maybe it should be case insensitive?
Again, this could be an option. If there's demand :)
This patch reworks the sentence stop detection. It addresses many tickets at once (with one "regression" though):
.
,?
,!
) : #6Support a blacklist option so anything can be explicitly excluded
etc.
i.e.
,.e.g.
...
Mr.
,Mrs.
.remarkrc
: