Closed whyboris closed 5 years ago
I think the full view scrolling issue has something to do with: https://github.com/rintoj/ngx-virtual-scroller#items-with-variable-size
I tried enabling unequal child sizes, but the detail view started acting badly! 😢
The only view that has variable sizes is the full-view
Somewhere in the code for the filmstrip, thumbnail, and file views I provide to the virtual-scroller the expected number of items to display (computed based on width and height of gallery view). This hasn't been done for the other views and so they are possibly wonky.
I'll review that part of code and find a solution for every view: it's easy enough to estimate how many elements will be displayed based on the app state 👌
Stress test the app with more than 1,000 videos in a hub
Phhffff 1,000? That's rookie numbers! I can confirm it works flawlessly with 20,000+ videos in a single hub, over a network, with each video having ~20 manual tags added as well! 🚀 ⚡️
😭 😁
Unfinished tasks moved to #234
This issue is to keep a list of tasks that should be done after all the new features we'd like to see in version 2.0.0 are added, but before the release occurs. Most of these tasks are on top of the issues tagged for
Milestone v2.0.0
This is a good place to see just how much needs to be done to make the current master release-ready. In no particular order:
Visual
Dark Mode
Code
console.log
statementsMisc
⚠️ Note -- unfinished tasks moved to #234