whyboris / Video-Hub-App

Official repository for Video Hub App
https://videohubapp.com
MIT License
568 stars 174 forks source link

browsing view history #524

Open lighthunt opened 4 years ago

lighthunt commented 4 years ago

In folder mode, when going up one level, the view would start from the top, not from the view I came to subfolder. Just like it is common when i.e. browsing web, going back in history, it would scroll the page to where I jumped off. (I am often browsing folders, so resetting view to top slows me down a lot). WDYT Please consider as enhancement sometime in the future.

whyboris commented 4 years ago

LOL 😅 I spent a bunch of time (and added lots of code) getting it to scroll down to the folder you initially clicked when you come back to the 'root' folder, when in Folder View 🤣

I thought it was a very-welcome feature -- thanks for sharing that it's not universally desirable 👍

It's probably easy to throw in yet another settings button for this 🤔

I hope I understood you correctly - you would like it to scroll to the top every time you navigate back to the root folder, when in folder view?

But then you say "resetting view to top slows me down" which makes me think you want the opposite behavior?

Could you clarify?

lighthunt commented 4 years ago

Reading my original comment, I have to admit it's confusing even to me now ;-), here is what the first sentence should say :

In folder mode, when going up one level, the view always starts from the top, not from the (scroll) position I came to subfolder.

LOL 😅 I spent a bunch of time (and added lots of code) getting it to scroll down to the folder you initially clicked when you come back to the 'root' folder, when in Folder View

YES, I agree with your point (assuming 'root' in your comment, you mean 'parent') -> I don't want to jump to top, but looks like it doesn't work that way for me (v2 and HEAD of main)

whyboris commented 4 years ago

I used 'root' because the code I added only works on the 'root' level -- the first view you get when you click folder view (for convenience assume no search filters were added or removed during your interactions with the folder view).

As I remember it, this is the current behavior. Hypothetically: 1) click folder view 2) scroll down to some folder like "movies" (in alphabetical order, let's say it's half-way down the scroll depth) 3) click on "movies" 4) scroll half way and click on some other folder "the best movies" 5) click the "Up" button to go back to "movies" 6) the scroll bar will not be in the same spot to see "the best movies" folder (right?) 7) click the "Up" button to go back to "root" (or you can use the breadcrumbs at the top) 8) the scroll bar should be somewhere so you can see "movies"

I added the feature to the root folder to scroll back to where I entered because that's what I wanted for myself; hoping that it would also be convenient for others.

It's not consistent behavior -- because when you do (5) it doesn't scroll to folder you clicked to enter 😅

The easiest behavior to implement is to always scroll to the top. I can add a button in settings that says "always scroll to top on folder navigation" 🤔

Please clarify. you'd rather the behavior was like (8) but for every folder navigation? Right?

idk commented 3 years ago

I have same issue as OP.

I believe the issue is exactly like you ask in your final reply @whyboris, in that "rather the behavior was like (8) but for every folder navigation."

whyboris commented 3 years ago

I will most likely leave the behavior as is for the initial 3.0.0 release (else, fixing all the small issues will delay the release by yet another few months). But I will keep this issue open 🤝

PR welcome for having the behavior (8) but for every folder navigation 😅