whyboris / Video-Hub-App

Official repository for Video Hub App
https://videohubapp.com
MIT License
591 stars 179 forks source link

Batch mode tagging: Changes to view should unselect all items #605

Open Orthodox-531 opened 3 years ago

Orthodox-531 commented 3 years ago

In batch mode, it's easy to accidentally apply a tag to unintended items because the view has changed to filter them. I believe the behavior would be less surprising if changing the view (filtering, randomizing) cleared all selected items.

whyboris commented 3 years ago

Thank you for the feedback.

First, a user requested a good feature: to show how many items are currently selected. I think it's relatively easy to do and is worth doing. This may address a part of the problem you're describing.

I sort-of feel like clearing the selected items while searching isn't the behavior I want. Specifically: I suspect someone might search for "comedies" and filter by something else, click "select all", and then remember that there are a few other videos that fall under the same tag, perform a separate search (e.g. "rofl movies") and then click to apply the tag 🤔

Perhaps, as long as there is a "number of videos selected" indicator next to the "Batch mode" button, it will be clear that many movies are selected besides the ones that are seen 🤔

Though I also see how it is easy-enough to forget. And it's similarly easy to just do a separate search and click the tag a 2nd time (required since every search would clear the currently-selected) ...

I'm unsure since I don't use tags and don't know what a comfortable 'workflow' would be.

You're probably right that clearing out all tags on search is useful.

I hope others weigh in 👂

whyboris commented 3 years ago

💡 I should also add a little notification (aka "toaster") that appears when you click on a tag - to notify user "N tags have been added" when they click on a tag 👍