whyboris / Video-Hub-App

Official repository for Video Hub App
https://videohubapp.com
MIT License
563 stars 172 forks source link

Custom thumbnails #722

Open KimKlvsgrd opened 2 years ago

KimKlvsgrd commented 2 years ago

It would be great if we could set custom thumbnails from our own image files, for example, cover files for movies like a front.jpg and back.jpg.

And also if you list the same video file from different storage sources, it would show up as double so it's easier to get rid of the duplicates. Or for those who want to, merge duplicates in the program so that only 1 source is shown.

whyboris commented 2 years ago

I wish I had this documented better. Currently you can drag any image (.jpg or .png) over any video thumbnail and it will set that image as the default thumbnail.

If the video is identical (has the same hash), the custom thumbnail should show up on both videos!

Let me know how it goes 😁

sebiimaks commented 2 years ago

Interestingly, I have a small number of videos for which thumbnails will not generate. On these, I can add a custom thumbnail by dragging an image onto the black thumbnail, but only if the resolution is 1080p or below. Customs will not work with 4k files. Strange.

whyboris commented 2 years ago

Thank you for the message! I'll take a look -- I'm surprised there is a restriction on maximum size, but I also understand why -- I'm using ffmpeg to do the reading and resizing of the image, so maybe it craps out on large sizes 🤔

sebiimaks commented 2 years ago

Ahh ok. But you would think that manually putting a screenshot in as a thumbnail would still work, no? Is ffmpeg involved in that process?

whyboris commented 2 years ago

I may be misunderstanding -- it sounds like you have no problem already with manually putting a screenshot in as a thumbnail at the moment - as long as the image you are dragging over from your computer is smaller than 4K in resolution 🤔 right ?

sebiimaks commented 2 years ago

Sorry, it is a little confusing. There is a group of files that won't generate thumbnails, but I can override this with the files within that group that are 1080p or under by manually adding a thumbnail by dragging over an image. This doesn't work for 4K files within that group. Generally, VHA has no problem with 4k files or the manual addition process.

I can understand ffmpeg bugging out and not allowing generation for 4K files, but why wouldn't the manual append process work? I hope that makes sense.

sebiimaks commented 2 years ago

By the way, your responsiveness as a developer is impressive, and I love the app. It's such a part of my workflow now that I find it hard to imagine life without it. I was just searching for a way to donate beyond my purchase donation, but I couldn't find one. You should add a PayPal/Stripe donate option to your website, or if you want to step over to the dark side, a Patreon!

Edit: I just found the Github sponsor option. Can you add some higher tiers? I'm good for at least $10 a month for a while.

whyboris commented 2 years ago

I'll try to replicate the bug you describe. I misunderstood initially, now I think I got it: adding a custom thumbnail works for your (for example) 1080p videos, but when you try to add a custom thumbnail to the 4K video, the app fails to do so :trollface:

I'm glad you're finding the app useful -- I created it initially as a "could be useful for me" but after a few months of development time I realized it would be useful for others if I just make the UI (user interface) nicer 😊

I made the app "pay what you want, $5 min" so some people end up paying more (usually $10). I also added a few buttons to donate on the website share page 😊

Thank you for the recommendation to add some more tiers to my GitHub Sponsors Page ❤️

sebiimaks commented 2 years ago

Some 4K files, yes. Cool, thanks again.