search

whyboris / Video-Hub-App

Official repository for Video Hub App
https://videohubapp.com
MIT License
596 stars 180 forks source link

Windows Package Manager upgrades full version to demo version #790

Open idk opened 1 year ago

idk commented 1 year ago

Hi, when I run winget upgrade in command prompt it thinks the demo version is an upgrade and it installs it.

PS C:\WINDOWS\system32> winget upgrade
Name                                                       Id                          Version      Available    Source

Video Hub App 3 3.1.0                                      whyboris.Video-Hub-App.Demo 3.1.0        3.1.0-demo   winget
Discord                                                    Discord.Discord             1.0.9006     1.0.9010     winget
Driver Booster 9                                           IObit.DriverBooster         9.3.0        10.2.0       winget
HandBrake 1.5.1                                            HandBrake.HandBrake         1.5.1        1.6.0        winget
ImageMagick 7.1.0-55 Q16-HDRI (64-bit) (2022-12-17)        ImageMagick.ImageMagick     7.1.0.55     7.1.0.60     winget
PC Manager(Beta)                                           Microsoft.PCManager         1.2.5.3      1.2.7.1      winget
OBS Studio                                                 OBSProject.OBSStudio        28.1.2       29.0.0       winget
PotPlayer-64 bit                                           Daum.PotPlayer              220706       221215       winget
Microsoft Visual C++ 2013 Redistributable (x64) - 12.0.30… Microsoft.VCRedist.2013.x64 12.0.30501.0 12.0.40664.0 winget
FACEIT Anti-Cheat                                          FACEITLTD.FACEITAC          2.0          2.1          winget
TeraCopy                                                   CodeSector.TeraCopy         3.9.2        3.9.7        winget
Microsoft Visual C++ 2013 Redistributable (x86) - 12.0.30… Microsoft.VCRedist.2013.x86 12.0.30501.0 12.0.40664.0 winget
12 upgrades available.
1 package(s) have version numbers that cannot be determined. Use --include-unknown to see all results.
whyboris commented 1 year ago

Hello, thank you for the report! I have never used winget and I'm unsure how my application got in there 😅

I do see the package (including my Simplest File Renamer 🎉 ) here: https://winget.run/search?query=boris and it seems like it's labeled as a Demo ✅ which is good:

https://winget.run/pkg/whyboris/Video-Hub-App.Demo

Did you ever use winget to install Video Hub App (Demo), or did winget just auto-detect you had the software and decided to upgrade you? 😓

whyboris commented 1 year ago

Looks like someone has come across this problem already 😅

https://github.com/microsoft/winget-pkgs/issues/45191

But they don't have a resolution for it yet 😔

idk commented 1 year ago

Hello, thank you for the report! I have never used winget and I'm unsure how my application got in there 😅

I do see the package (including my Simplest File Renamer 🎉 ) here: https://winget.run/search?query=boris and it seems like it's labeled as a Demo ✅ which is good:

https://winget.run/pkg/whyboris/Video-Hub-App.Demo

Did you ever use winget to install Video Hub App (Demo), or did winget just auto-detect you had the software and decided to upgrade you? 😓

It just auto detected it (as it should, I think, as it also updates other paid software, such as syncbackfree pro, teracopy, etc. using the authors download links), it's a wonderful program, just not in this instance, that's why I reported it as I'm sure others will encounter this issue as it should handle ALL programs installed no matter if paid installed/demo programs. As for how to remedy it, I've no clue sorry. It was easily fixed on my end by reinstalling the normal version of VHA but the pending upgrade remains in winget.

I hope they resolve it as to me it looks like a simple fix/naming version convention or something?

jan-oratowski commented 1 year ago

@idk @whyboris I was the person that reported it as a winget issue, just responded there. If you need me for something, just drop me a message.

whyboris commented 1 year ago

I released version 3.2.0 with some adjustments to the naming convention -- so I think the demo will no longer try to overwrite the app installed with winget. But I was unsure how to (where to) set Publisher.Package when building the app - so it might not be as good as it should be 😓

Is this where it happens? https://github.com/whyboris/Video-Hub-App/blob/main/electron-builder.json#L3 -- I looked around the electron-builder documentation and couldn't figure it out 😔

Release: https://github.com/whyboris/Video-Hub-App/releases/tag/v3.2.0