whyboris / Video-Hub-App

Official repository for Video Hub App
https://videohubapp.com
MIT License
591 stars 179 forks source link

Add optional password to hub #842

Open whyboris opened 9 months ago

whyboris commented 9 months ago

⚠️ this would not be "super secure" but simply to prevent snooping by someone.

People over the years requested this 🤷‍♂️ seems easy to implement 😅

note: this means opening the .vha2 file one can easily read the password 👌 ... though to make it more secure we can (salt and then) hash the password and check the hash 🥳

whyboris commented 9 months ago

I'm open to the discussion:

Should the (optional!) password be for the app or per hub?

minazaher commented 4 months ago

Can I work on this issue?

whyboris commented 4 months ago

Hey @minazaher thank you for the offer! Please give this a go 🤝

Please let me know if you have any questions along the way - I'm happy to assist 😁

For the user to add / remove / change the password - let's put the UI in the 4th tab in settings ("Current hub")

olorunfemisamuel commented 2 months ago

Can I work on this issue, too?

whyboris commented 2 months ago

Hey @olorunfemisamuel - please feel free to try this issue out 🤝 Let me know if you have any questions along the way 👍

ayyash1 commented 1 month ago

Can you /assign this to me?

whyboris commented 1 month ago

Hey @ayyash1 - let me know if you have any questions as you try adding this feature 🤝

whyboris commented 1 month ago

Thank you @ayyash1 for the Pull Request https://github.com/whyboris/Video-Hub-App/pull/865 🙇‍♂️ - I intend to merge it when I resume work on VHA this winter 🤝