search

whyisjake / Simple-Instant-Articles-for-Facebook

Add support for Facebook Instant Articles to your WordPress site.
https://wordpress.org/plugins/simple-facebook-instant-articles/
55 stars 19 forks source link

Allow for endpoint on article links to be used for query vars or not at all #37

Closed AramZS closed 8 years ago

AramZS commented 8 years ago

This provides a useful solution to #34

whyisjake commented 8 years ago

I like this solution, as a I think as a default we should leave the endpoint open. Since there is a canonical URL, we don't need to worry about any SEO implications.

I am going to do a little testing, and then will likely merge.

AramZS commented 8 years ago

@whyisjake great!

dashaluna commented 8 years ago

Cross posting comment here from #39 as I don't know which branch will make it in first. I have noticed some WP PHP Coding Standards issues. Do you want me to clean them up in a commit or add comments to this PR and you can do it? I don't mind either way, but would be great to fix them before merge :) Sorry for nitpicking!

whyisjake commented 8 years ago

@dashaluna, I went ahead with the merge. Wanted to get this out, but we should still update to the coding standards. I'll take a stab at cleaning things up, but a PR is welcome too. :)

whyisjake commented 8 years ago

@AramZS, this was a huge pull. thanks for the great work!

AramZS commented 8 years ago

@whyisjake Much thanks!