whyoleg / cryptography-kotlin

Kotlin Multiplatform cryptography / crypto library
https://whyoleg.github.io/cryptography-kotlin/
Apache License 2.0
337 stars 19 forks source link

CRC support #28

Closed sjaramillo10 closed 7 months ago

sjaramillo10 commented 7 months ago

Hey there 👋

I just started using the BigInt functionality of this library and a slightly different use case came across: CRC (Cyclic Redundancy Check). Would that be in-scope for this library? If so, how likely is it to be supported? Thanks!

whyoleg commented 7 months ago

Hey, thank you for your interest! Unfortunately, at least for now, I don't see CRC fitting the scope of the library. I think, that CRC could be a part of IO library (like kotlinx.io) and not part of cryptography library. F.e okio has internal CRC implementation for ZIP support.

sjaramillo10 commented 7 months ago

Thanks for replying back!

I understand, makes sense. I ended up implementing the functionality myself, which is not that hard honestly. I did not know that okio had an internal implementation for that, I could’ve used it for inspiration 🤔

I am closing this issue, keep up the good work 🙌