whyour / qinglong

支持 Python3、JavaScript、Shell、Typescript 的定时任务管理平台(Timed task management platform supporting Python3, JavaScript, Shell, Typescript)
https://qinglong.online
Apache License 2.0
15.66k stars 2.91k forks source link

python自定义消息通知修改 #2328

Closed Akimio521 closed 4 months ago

Akimio521 commented 5 months ago

PR Type

What kind of change does this PR introduce?

What is the current behavior?

Issue Number: #2324 #2285

What is the new behavior?

Does this PR introduce a breaking change?

Other information

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
qinglong ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 3:27am
qinglong-back ✅ Ready (Inspect) Visit Preview 💬 Add feedback Apr 9, 2024 3:27am
Cp0204 commented 5 months ago

@whyour 可以分配我 assignee 吗?

Cp0204 commented 5 months ago

@whyour 可以分配我 assignee 吗?

@Akimio521 或者我给你发了个PR https://github.com/Akimio521/qinglong/pull/1 ,你看下是不是更简洁。

不用多存一个 key list ,就算 kwargs 写错,push_config 的 key 多了不要紧,少了也不要紧,后面都会检查,不影响。

Akimio521 commented 5 months ago

@whyour 可以分配我 assignee 吗?

@Akimio521 或者我给你发了个PR Akimio521#1 ,你看下是不是更简洁。

不用多存一个 key list ,就算 kwargs 写错,push_config 的 key 多了不要紧,少了也不要紧,后面都会检查,不影响。

已经合并PR

Cp0204 commented 5 months ago

😜cool~

whyour commented 5 months ago

custom_notify、parse_string、parse_body 删多了

Cp0204 commented 5 months ago

custom_notify、parse_string、parse_body 删多了

收到,应该是回滚掉了后面的 commit ,我检查一下