search

whyrusleeping / gx-go

gx subtool for golang
MIT License
80 stars 28 forks source link

Rewrites broken in symlinked directories #19

Open parkan opened 7 years ago

parkan commented 7 years ago

I like to symlink dirs out of GOPATH and into my normal working tree, however this seems to silently break gx-go rewrites.

The offending line appears to be here: https://github.com/whyrusleeping/gx-go/blob/master/rewrite/rewrite.go#L33

whyrusleeping commented 7 years ago

Hrm... Can you provide me a quick example of your setup? like, what your GOPATH is and where your symlinks are? i'll try to reproduce the issue and fix it

ghost commented 7 years ago

@parkan independent of this particular issue, I've been symlinking from gopath to workspace in the past as well, but now I symlink the other way around, I have all of the ipfs/libp2p/ipld/multiformats repos in my workspace, and symlink the ipfs/etc. dirs into gopath/src/github.com, which works nicely.

parkan commented 7 years ago 
[mine]% ls -ld concat
lrwxr-xr-x  1 arkadiy  staff  50 Oct 12 15:31 concat -> /Users/arkadiy/go/src/github.com/mediachain/concat
[mine]% pwd
/Users/arkadiy/mine
[mine]% cd concat
[master//concat]% gx-go rewrite                                            
# nothing happens
[master//concat]% echo $GOPATH
/Users/arkadiy/go
[mine]% cd $GOPATH/src/github.com/mediachain/concat                                       
[master//concat]% gx-go rewrite
# works

I'll try symlinking the other way around