search

whyrusleeping / gx-go

gx subtool for golang
MIT License
80 stars 28 forks source link

Fix #19 #22

Closed timotree3 closed 4 years ago

timotree3 commented 7 years ago

This pull request fixes #19 in a way consistent with the current code.

I think the issue was caused by the fact that the gx.GetPackageRoot() function uses os.Getwd() but doesn't evaluate symlinks. The desired behaviour as illustrated by the top-level cwd variable is to evaluate symlinks after using os.Getwd().

This pull request makes this behaviour consistent by evaluating symlinks in gx.GetPackageRoot()'s output.

whyrusleeping commented 7 years ago

@lgierth mind reviewing this? I don't use symlinks in my workflow at all

whyrusleeping commented 6 years ago

Fixed in #26