whyrusleeping / gx-go

gx subtool for golang
MIT License
80 stars 28 forks source link

Review `fixImports` #42

Open schomatis opened 6 years ago

schomatis commented 6 years ago

Why is it necessary? Why is it not incorporated in the normal flow of the gx-go rewrite command and needs to be called separately with the --fix flag?

In the go-unixfs repo it is necessary to call this function (through --fix) because rewrite --undo (and hence gx-go link -r) is not working.

whyrusleeping commented 6 years ago

@schomatis i have it as a separate option because you ideally shouldnt have to use it, plus it is hypothetically slower than the normal gx-go rw/uw commands