search

whyrusleeping / gx

A package management tool
MIT License
1.88k stars 110 forks source link

Low hanging lint changes #155

Closed djdv closed 6 years ago

djdv commented 6 years ago

I ran gometalinter while making some changes, it caught several actual issues related to Errorf calls, and made some simplification suggestions, there is also a single change to conform to error conventions (don't end in a period). I committed the suggested changes excluding: warnings about shadowing vars, documentation, and permission/security settings. I don't plan on addressing those.

djdv commented 6 years ago

I don't know what's going on with Travis （ ´_ゝ｀）

djdv commented 6 years ago

I think it was failing because of the old Go version. Rebased and it's fine now. ping @whyrusleeping

whyrusleeping commented 6 years ago

Thanks @djdv :)

djdv commented 6 years ago

My bad. 😬 https://github.com/whyrusleeping/gx/pull/156

Will this impact the repo size in a way that needs intervention?