search

whyrusleeping / gx

A package management tool
MIT License
1.88k stars 110 forks source link

don't ignore vendored code by default #186

Closed Stebalien closed 6 years ago

Stebalien commented 6 years ago

The user should either:

  1. Add it to the .gxignore file if they want to support both gx and vendoring.
  2. Delete it from the repo when gxifying it.

fixes #185

Thoughts @whyrusleeping? I'm pretty sure this won't break any of our existing uses of gx and this is a more language independent solution than the current one.

whyrusleeping commented 6 years ago

@Stebalien SGTM, i forget my reasoning for doing this in the first place

Stebalien commented 6 years ago

The reason was probably to support both vendored and gxed deps. However, that can be done with an ignore file. It may also have been done to handle the gx-go devcopy case.

Stebalien commented 6 years ago

@marten-seemann does this fix your issue?

marten-seemann commented 6 years ago

Yes. That was exactly the temporary fix I applied to gx-publish quic-go.

Stebalien commented 6 years ago

Git it. I'll take the SGTM from @whyrusleeping as a signoff.