Closed schomatis closed 5 years ago
Unrelated test error fixed in #198, needs to rebase after merge.
I have to finish the documentation and fix some minor details but this change already shows a considerable performance improvement. Before finishing this up I need a green light from @whyrusleeping to raise the ratelim
(now called maxGoroutines
) from the original value of 2 (now 20, but could be any number) as I'm not sure what was the original rationale for this low number, but raising it was the original motivation behind this entire PR.
@Stebalien WDYT about raising the number of goroutines fetching dependencies?
WDYT about raising the number of goroutines fetching dependencies?
If it helps, do it.
@Stebalien Ready for review.
@Stebalien Fixed. Thanks for catching the goroutines bug!
Oh, this is nice! Thanks @schomatis!
I hacked a towards making this a tiny bit cleaner in #206, but this is far cleaner. If @Stebalien is happy with the changes, i'd be down to merge this, then rebase #206 on top and make the 'cache fetch linking' stuff there use this new code.
Yes, this looks good now.
Closes #195.