search

whythawk / full-stack-fastapi-postgresql

Full stack, modern web application generator. Using FastAPI, PostgreSQL as database, Nuxt3, Docker, automatic HTTPS and more.
MIT License
231 stars 47 forks source link

Commented COPY in backend.docker #38

Closed a-vorobyoff closed 11 months ago

a-vorobyoff commented 11 months ago

Why is "COPY ./app/ /app/" commented out in backend.dockerfile? I wasted some time trying to find the problem.

turukawa commented 11 months ago

Apologies, I think that interferes with Alembic, right? I'll make the fix ...

a-vorobyoff commented 11 months ago

Yes, Alembic. Additionally, I think it would be helpful to mention in the documentation that the project has switched from Poetry to Hatch. I was a bit confused when reading the original README.md and trying to set up the environment in my IDE. A big thank you for continuing to support the project!

turukawa commented 11 months ago

OK, fixed and tested.

Re Hatch, it's in the release notes for 0.7.4, and here. I had hassles with integrating this and that's probably where this particular error happened.