whywaita / myshoes

Auto-scaling VirtualMachine runner 🏃 for GitHub Actions
MIT License
132 stars 13 forks source link

Default is actually check_run #201

Closed alfred-stokespace closed 3 months ago

alfred-stokespace commented 4 months ago

I found this today on my own instance of myshoes.

2024/05/02 19:40:00 receive WorkflowJobEvent, but set check_run. So ignore

I checked the code ... https://github.com/whywaita/myshoes/blob/603c51b07c194f6d0e98218b65a5568ce8e3fc2c/pkg/config/init.go#L63

and indeed the default is not workflow_job

whywaita commented 3 months ago

@alfred-stokespace Nice catch! Thank you. Also, I plan to change the default to workflow_run after this, as check_run is already a deprecated format.