Populate labels in the generated script.

whywaita / myshoes

Auto-scaling VirtualMachine runner 🏃 for GitHub Actions

MIT License

132 stars 13 forks source link

Populate labels in the generated script. #202

Open alfred-stokespace opened 4 months ago

alfred-stokespace commented 4 months ago

As mentioned https://github.com/whywaita/shoes-aws/pull/2#issuecomment-2093526663 in sister PR https://github.com/whywaita/shoes-aws/pull/2

now that I'm doing full integration testing, it is clear that the script needs the labels from GH otherwise jobs won't schedule.

whywaita commented 3 months ago

@alfred-stokespace Sorry, my response is late.

Your suggestion is not bad. But it has a problem of security. I’m afraid of any code execution. So, Could you add an option that “is populate labels”? myshoes will populate labels if true.

alfred-stokespace commented 3 months ago

@alfred-stokespace Sorry, my response is late.

Your suggestion is not bad. But it has a problem of security. I’m afraid of any code execution. So, Could you add an option that “is populate labels”? myshoes will populate labels if true.

Good point! @whywaita I should have considered that. Thanks.