The target error status is always overwritten to active by the lines below

whywaita / myshoes

Auto-scaling VirtualMachine runner 🏃 for GitHub Actions

MIT License

132 stars 13 forks source link

The target error status is always overwritten to active by the lines below #79

Closed chez-shanpu closed 2 years ago

chez-shanpu commented 3 years ago

https://github.com/whywaita/myshoes/blob/98029fde1ef4fe198d93b21f07002480ffbfc0eb/pkg/runner/runner.go#L167-L184

When the deleteRunner function is failed, target status becomes "error", but the lines below (L179~182) always set the status as "active". Therefore the target status will be always "active" even though all the runner deletion was failed.

whywaita commented 2 years ago

Thank you for the issue!

I fixed it in #112 💪