weihsth
commented
7 months ago After checking the lib code, I found out, that I am not allowed to set the response_type. For example for lokal development I am always using response_type: 'token', which is also supported by AppAuth-JS. Is there a reason, why this part is hard codet in the module lib source code? Do you plan to change this?
performAuthorizationRequest(authExtras, state) {
return __awaiter(this, void 0, void 0, function* () {
let requestJson = {
response_type: AuthorizationRequest.RESPONSE_TYPE_CODE, // <--- not possible to configure :(
client_id: this.authConfig.client_id,
redirect_uri: this.authConfig.redirect_url,
scope: this.authConfig.scopes,
extras: authExtras,
state: state || undefined,
};
let request = new AuthorizationRequest(requestJson, new DefaultCrypto(), this.authConfig.pkce);
if (this.authConfig.pkce)
yield request.setupCodeVerifier();
return this.requestHandler.performAuthorizationRequest(yield this.configuration, request);
});
}I am still not able to find out, why this.notifier seems to be undefined here, but I hope someone can provide some hint what I missed during implementation. I compared my code with the capacitor example several times now. It's the same code, but not working. I also tested installing optionalDependencies, but nothing changed so far.
The code, where the initial "error" message is coming from:
/**
* Completes the authorization request if necessary & when possible.
*/
completeAuthorizationRequestIfPossible(): Promise<void> {
// call complete authorization if possible to see there might
// be a response that needs to be delivered.
log(`Checking to see if there is an authorization response to be delivered.`);
if (!this.notifier) {
log(`Notifier is not present on AuthorizationRequest handler.
No delivery of result will be possible`)
}
return this.completeAuthorizationRequest().then(result => {
if (!result) {
log(`No result is available yet.`);
}
if (result && this.notifier) {
this.notifier.onAuthorizationComplete(result.request, result.response, result.error);
}
});
}How to make sure, this.notifier is set? When I look into the code, it's coming from @openid/appauth module, and I installed this module. I can not find any code in the example, where I need to setup Notifier on my own.
And the redirect works.. I have all the parameters in the redirect URL:
and I call th needed function in the callback Component:
async ionViewWillEnter() {
this.sub = this.authService.events$.subscribe((action) => this.handleAuthEvent(action));
this.authService.authorizationCallback(window.location.origin + this.router.url);
}Callback Component console log output:
{action: 'Init'}
Checking to see if there is an authorization response to be delivered.
Notifier is not present on AuthorizationRequest handler.
No delivery of result will be possible
dmoojunk
Hi folks, thank you for this great plugin and the effort of adding examples!
I already searched through the open issues and googled a lot, but can not find any helping advices for my bug(?).
Using the capacitor example code the project compiles without errors. Login and redirect (locally) is working well until it comes to calling auth.authorizationCallback(). This always ends up in a dev-tools-termin message like this:
My authConfig (KeyCloak) looks like this:
Client is public and was working with another oidc plugin I used before. I switched to yours because of ionic app support.
auth.factory.ts:
The '/auth/callback' is reached, bot nothing happens on this page. It shoul redirect me to "/home" after checking the auth code. I dont even see any "/token" request in the dev tools, so the auth code is not handled.
I see the callback-URL with all the parameters in the Browser address field. When refreshing the browser, I can see this error event:
The auth.init() is called in AppComponent constructor after platform.ready(). Also tried to run the init before platform.ready(). Does not matter. From the source code I see, that the notifier should be set up when calling init() funtion. But seems, it does not.
Since I cannot find any advices in documentation about which kind of Notifier or AuthorizationRequest handler is ment, I ask you kindly for giving me any advice, link or example, what I need to adjust.
I checked code a lot of times and even went throgh cordova and other example code. There is nowwhere a setup für this kind of classes.
Regards!
Addendum: Tested with Android (deployed via Android Studio). Redirect to login works. Redirect back to /auth/callback works, but from the $events observable I get this error:
I looked in the capacitor example code again and can not find any "handle" setup.