wichert / lingua

Translation toolkit for Python
Other
46 stars 32 forks source link

lingua_xml does not pick up all items to be translated #5

Closed AnneGilles closed 12 years ago

AnneGilles commented 12 years ago

I just looked at Pylons/deform to add some translations. I had to change the message extractors to lingua, as chameleon_xml/python simply issn't availabel in chameleon2, afair.

After running bin/python setup.py extract_messages I noticed there were not more but less things to be translated, because some things from small template snippets are not picked up. If I remember linguas code right, you check for the namespace declaration to be present. Here it isn't.

examples:

diff --git a/deform/locale/deform.pot b/deform/locale/deform.pot index da3aa98..27210b1 100644 --- a/deform/locale/deform.pot +++ b/deform/locale/deform.pot @@ -6,9 +6,9 @@

, fuzzy

msgid "" msgstr "" -"Project-Id-Version: deform 0.9.2\n" +"Project-Id-Version: deform 0.9.3\n" "Report-Msgid-Bugs-To: EMAIL@ADDRESS\n" -"POT-Creation-Date: 2011-08-10 09:33+0200\n" +"POT-Creation-Date: 2011-11-15 17:20+0100\n" "PO-Revision-Date: YEAR-MO-DA HO:MI+ZONE\n" "Last-Translator: FULL NAME EMAIL@ADDRESS\n" "Language-Team: LANGUAGE LL@li.org\n" @@ -53,66 +53,7 @@ msgstr "" msgid "Add ${subitem_title}" msgstr ""

-#: deform/widget.py:1235 +#: deform/widget.py:1226 msgid "Incomplete date" msgstr ""

-#: deform/templates/checked_password.pt:10 -msgid "Confirm Password"

-msgstr ""

-#: deform/templates/checked_password.pt:5 -msgid "Password" -msgstr ""

and some extract from that template (with no namespace declaration, though using):

wichert commented 12 years ago

The next step would be to fix the template to correctly declare the i18n namespace.

AnneGilles commented 12 years ago

done.

https://github.com/AnneGilles/deform/commits/master

kiorky commented 12 years ago

If you want translations for deform you can look https://github.com/kiorky/deform as i wanted also to translate it in french last week, and also my pull request on https://github.com/Pylons/deform.

On the other hand, you can look on lingua pull request #6 (IOW my fork of lingua in https://github.com/kiorky/lingua) or a fix to extrat msgids from missing declaring namespace templates.