Closed suvanbanerjee closed 6 months ago
Hey, this looks good but a couple things; Switching to dnf
from defined _dnf
means it doesn't hide/show the cursor as expected. And did the _dnf show -C
command not work as expected? If not can we still use _dnf or else should set the cursor similar to other operations
Also you can push to existing PRs and make changed without making seperate ones. Wasn't sure if you knew! Thanks for taking your time to do this!
Hey, this looks good but a couple things; Switching to
dnf
from defined_dnf
means it doesn't hide/show the cursor as expected. And did the_dnf show -C
command not work as expected? If not can we still use _dnf or else should set the cursor similar to other operationsAlso you can push to existing PRs and make changed without making seperate ones. Wasn't sure if you knew! Thanks for taking your time to do this!
https://github.com/wick3dr0se/pkm/pull/6/files#diff-745754526126bd92a9131cfc73ed4a5441da5a33b31d66f242ead3bfc24bae1aR6-R7
If in this case we have 3 args that will be passed to _dnf hence it if only execute dnf -C info
that will list all apps so one way is to add an if condition exclusively for the info. I will be sending PR for that
Ahh ok that makes sense.. So we could really just hide cursor and show it instead of using the _dnf function. No big deal, I'll merge this! And thanks for explaining too!
closes #5