wickedest / Mergely

Merge and diff documents online
http://www.mergely.com
Other
1.17k stars 228 forks source link

Accent insensitive search text #132

Open dzapata14 opened 4 years ago

dzapata14 commented 4 years ago

Hi everyone,

I write you because I don´t find any option to do accent insensitive search, Is possible to make an accent insensitive search? If a do a search in a spanish text I get differents results if I type the word with accent and without accent.

Regards!!!

wickedest commented 4 years ago

@dzapata14, it works for me. Are you using this on mergely.com, or did you integrate it into your own application?

dzapata14 commented 4 years ago

Hi @wickedest, thanks for your help

I am using mergely in my own application. This is how I initialize:

$("#objeto").mergely({ width: 90, height: 60, cmsettings: { mode: "text/html", readOnly: true, lineNumbers: true, lineWrapping: true }, sidebar: false , ignorews: true , ignorecase: true , viewport: true , sidebar: false });

In the following link you can see the results.

mergely.docx

If I search the word constitución I got several results, but I search the word constitucion I only got one result.

I am using Mergely Version: 3.4.0

image

What do you think It is missing?

Regards!!!

wickedest commented 4 years ago

On https://editor.mergely.com, it works for me - try it yourself. I'd look into your character encoding. You want utf-8 everywhere. your web pages, the content you are rendering, your DB, etc.

On Thu, 10 Sep 2020 at 15:19, dzapata14 notifications@github.com wrote:

Hi @wickedest https://github.com/wickedest, thanks for your help

I am using mergely in my own application. This is how I initialize:

$("#objeto").mergely({ width: 90, height: 60, cmsettings: { mode: "text/html", readOnly: true, lineNumbers: true, lineWrapping: true }, sidebar: false , ignorews: true , ignorecase: true , viewport: true , sidebar: false });

In the following link you can see the results.

mergely.docx https://github.com/wickedest/Mergely/files/5202234/mergely.docx

If I search the word constitución I got several results, but I search the word constitucion I only got one result.

I am using Mergely Version: 3.4.0

[image: image] https://user-images.githubusercontent.com/43120791/92743586-5060c180-f346-11ea-8471-940b84a20886.png

What do you think It is missing?

Regards!!!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/wickedest/Mergely/issues/132#issuecomment-690320790, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAGUZV7ZS6IT5D7MJNPMI6DSFDN7FANCNFSM4RDN4HTQ .

dzapata14 commented 4 years ago

Hi @wickedest, thanks for your help

I am doing the test online but It doesn work, If i search the word constitucion only got results in lines 2 and 3, not match with line 1. What options allows me that match with line 1.

image

Regards!!!

wickedest commented 4 years ago

Ah, I completely misread what you were asking. I thought you were saying that it was accent insensitive. There's no way to enable that out of the box.

dzapata14 commented 4 years ago

Ok @wickedest, I appreciate your help, Do you think this functionality can be developed in the future?

wickedest commented 4 years ago

I doubt I'd get to it, not for a long time anyway. I labeled in enhancement and Hacktoberfest. Maybe someone's eager for a new T-shirt.

wickedest commented 4 years ago

Also added feature to https://editor.mergely.com

dzapata14 commented 4 years ago

Hi @wickedest, thanks for your help,

I am testing online but It doesnt work. I am searching the word constitucion and I activated the "ignored accented characters" but I got the words constitucion and constitucionalidad, but the word constitución is not int result.

image

image

Regards!!!!

wickedest commented 4 years ago

And again, I got it wrong. All of those "Ignore" options are for the diff, which confused me. Clearly, you want the "search" feature to be case insensitive. You were clear the whole time. Anyway, that's a problem - most of the search feature comes directly from CodeMirror search and searchcursor, and they don't seem to have that option. It'd be a good feature to add. I created a ticket there: https://github.com/codemirror/CodeMirror/issues/6448.