TinyMCE6: /current/ in Webjar URL

[f-wunderlich]

The wicketstuff-tinymce6 module hardcodes the path to the TinyMCE JS in the Webjar with "current" instead of the version number. How is that supposed to work?

TinyMCESettings: public static final ResourceReference TINYMCE_JS_REF = new JavaScriptResourceReference( TinyMceBehavior.class, "../../../webjars/tinymce/current/tinymce.js"); public static final ResourceReference TINYMCE_JS_REF_MIN = new JavaScriptResourceReference( TinyMceBehavior.class, "../../../webjars/tinymce/current/tinymce.min.js");

pom.xml:

org.webjars.npm

        <artifactId>tinymce</artifactId>
        <version>6.8.3</version>

$ jar tf ~/.m2/repository/org/webjars/npm/tinymce/6.8.3/tinymce-6.8.3.jar | grep tinymce.js META-INF/resources/webjars/tinymce/6.8.3/tinymce.js

Unsurprisingly, the example does not work: $ mvn -Dexec.mainClass=org.wicketstuff.examples.tinymce.Start -Dexec.classpathScope=test test-compile exec:java [...] [qtp493343679-81] WARN org.apache.wicket.request.resource.PackageResource - resource [path = webjars/tinymce/current/tinymce.js, style = null, variation = null, locale = null]: Unable to find resource (status=404)

Either change the path in TinyMCESettings to match the Webjar ("6.8.3" instead of "current"), or use something like org.webjars:webjars-servlet-2.x and get rid of the "current/" segment in the path.

As far as I can tell, this "current" segment is only generated by de.agilecoders.wicket.webjars:wicket-webjars which is quite useless as it only works for its own IWebjarsResourceReference derived classes (see WebjarsResourceFinder#find) and with a massive amount of code only replicates what the container does anyway. In any case, neither is this artifact used by the TinyMCE6 module, nor would it work if it was, since TinyMCESettings declares standard JavaScriptResourceReferences.

[martin-g]

@renoth ^^

[martin-g]

@f-wunderlich The idea is to use current + WebjarsResourceReference and update the version only in pom.xml. Using JavaScriptResourceReference must be a mistake.

It is not very clear how https://github.com/webjars/webjars-servlet-2.x works from its README. It might do the same or something else. I cannot tell...

[f-wunderlich]

For de.agilecoders.wicket.webjars:wicket-webjars I believe the following is necessary:

• add a dependency in pom.xml
• invoke WicketWebjars.install(this) in TinyMCE6ExampleApplication#init
• replace the JavaScriptResourceReference in TinyMCESettings with WebjarsJavaScriptResourceReference

The org.webjars:webjars-servlet-2.x artifact is documented at the official Webjars website: https://www.webjars.org/documentation#servlet2 It is useless for anything halfway modern since it uses javax.servlet classes and can only serve as an example on how to make web applications agnostic of the webjar version they are using with maybe 20 lines of code: https://github.com/webjars/webjars-servlet-2.x/blob/master/src/main/java/org/webjars/servlet/WebjarsServlet.java

[martin-g]

@f-wunderlich Do you want to send a Pull Request?

[renoth]

IMHO it doesnt matter that much anymore because TinyMCE 6 is EOL tomorrow https://github.com/tinymce/tinymce/discussions/9609 and TinyMCE 7 self hosted will be GPLv2 which will make it unusable for most people. Any good alternatives with Wicket?

Shitstorm-Thread here https://github.com/tinymce/tinymce/discussions/9496