search

wicketstuff / core

Wicketstuff-core projects are bundled user contributions for use with Apache Wicket (https://wicket.apache.org/). They are released in step with Wicket releases to make them easy to use.
342 stars 298 forks source link

wicketstuff-push-cometd regression issue, wrongly located js files #151

Open ghost opened 12 years ago

ghost commented 12 years ago

When trying to use cometd you end up with a list of warnings that the application fails to load several js files: WARN [100912 08:11:35] - (376)PackageResource - resource [path = org/wicketstuff/push/cometd/cometd.js, style = null, variation = null, locale = null]: Unable to find resource (status=404) WARN [100912 08:11:35] - (376)PackageResource - resource [path = org/wicketstuff/push/cometd/cometd/ReloadExtension.js, style = null, variation = null, locale = null]: Unable to find resource (status=404) WARN [100912 08:11:35] - (376)PackageResource - resource [path = org/wicketstuff/push/cometd/cometd/TimeSyncExtension.js, style = null, variation = null, locale = null]: Unable to find resource (status=404) WARN [100912 08:11:35] - (376)PackageResource - resource [path = org/wicketstuff/push/cometd/cometd/AckExtension.js, style = null, variation = null, locale = null]: Unable to find resource (status=404) WARN [100912 08:11:35] - (376)PackageResource - resource [path = org/wicketstuff/push/cometd/cometd/TimeStampExtension.js, style = null, variation = null, locale = null]: Unable to find resource (status=404)

This was fine when using wicketstuff-push-cometd-1.5.8. Now I'm migrating to wicket 6.0, so the dependency has been upgraded to wicketstuff-push-cometd-6.0.0-beta3. This issue relates to issues #100 & #118

The files are actually located now under "org/wicketstuff/push/cometd/org/cometd/*.js"

Kind regards, Marco Springer

ghost commented 12 years ago

In a follow-up note, I've just updated the wicketstuff dependency to 6.0.0 from 6.0.0-beta3.

The behavior remained the same. What I did notice, the "CometdPushBehavior" seems to have the correct reference to the JS files but probably due to the way how the "Packages" class works, the "org" part gets stripped off.

I'd suggest putting those js files under something like "res/comet.js" & "res/cometd/*.js". Or is there a reason why it's being put under a second "org" package path?

regards, Marco

ghost commented 12 years ago

And as an added bonus, #77 seems to have returned as well.

Uncaught exception: TypeError: 'Wicket.Event.addDomReadyEvent' is not a function Error thrown at line 151, column 2 in http://localhost:8080/?12: Wicket.Event.addDomReadyEvent(function(){